Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esql qa resources to conf.yaml #2732

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

ChrisHegarty
Copy link
Contributor

This commit adds the x-pack/plugin/esql/qa/testFixtures/src/main/resources resource for building the Elasticsearch. The directory contains files that are used for code snippet testing.

Currently only required for the feature/esql branch, but will be required for main once merged, post 8.10.

@ChrisHegarty
Copy link
Contributor Author

This is similar to what @nik9000 proposed over in 2678

conf.yaml Outdated Show resolved Hide resolved
Co-authored-by: Abdon Pijpelink <[email protected]>
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty merged commit 1af3ccc into elastic:master Aug 11, 2023
@ChrisHegarty ChrisHegarty deleted the esql_resources_link branch August 11, 2023 08:08
@nik9000
Copy link
Member

nik9000 commented Aug 15, 2023

I'm just getting to this. It looks right. Welcome to the giant yaml file that runs all the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants